initial commit #5839
Open
initial commit #5839
+56
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aazam Thakur <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5839 +/- ##
==========================================
+ Coverage 36.31% 36.34% +0.02%
==========================================
Files 1304 1304
Lines 110048 110148 +100
==========================================
+ Hits 39969 40032 +63
- Misses 65923 65948 +25
- Partials 4156 4168 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@aazam-gh thanks for the pr. will let @davidmirror-ops comment on this when he's back next week, but this pr looks good. You tested the changes in demo cluster? Also this pr doesn't close out the entire issue right? There's a couple other changes it needs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Fixes #5738
Why are the changes needed?
In order to ensure that this example is reproducible.
What changes were proposed in this pull request?
Updating
index.rstunder docs/deployment/pluginsHow was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link